Antalya 26.6: Cache vended credentials for REST catalogs - #2156

Workflow [PR], commit [6f076f7]

@blau-ai

@blau-ai

CI triage

Verdict: 11 red checks — 0 caused by this PR. Every failure is pre-existing on antalya-26.6, a known-flaky test, or an infra glitch in the CI tooling. None of them touch the files or code paths this PR changes (REST-catalog vended-credentials caching + Azure buffers). All build flavors that had a valid cache/config compiled the PR's own code cleanly.

Build (amd_msan) / Build (arm_msan) — pre-existing base-branch break

FAILED: .../Iceberg/IcebergWrites.cpp.o
/ClickHouse/src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp:179:28:
error: use of undeclared identifier 'getDecimalScale'

IcebergWrites.cpp is not in this PR's diff. getDecimalScale is declared in DataTypes/DataTypesDecimal.h, which the file does not #include (and none of its included headers pull it transitively). It compiles everywhere else only because ccache serves a stale object; the msan flavor rebuilds from source and hits the real error.

Proof it's pre-existing: the base branch's own MasterCI run 31142308506 (started ~4h before this PR's run) fails with the identical getDecimalScale error at IcebergWrites.cpp:179.

This is what blocks all the msan-dependent jobs (they show as dropped, not run).

Fix (belongs on antalya-26.6, not this PR): add #include <DataTypes/DataTypesDecimal.h> to src/Storages/ObjectStorage/DataLakes/Iceberg/IcebergWrites.cpp. That one line unblocks msan for every PR against the branch. I can open it as a separate blau/* PR if you'd like — just say the word.

Unit tests (asan_ubsan) / Unit tests (tsan) — pre-existing

Both fail on the same gtest throwing Code: 1001, std::runtime_error, e.what() = rebuild failed, in the DiskAccessStorageRecovery access-storage suite. Deterministic across both sanitizers, no connection to DataLake/Azure. Not introduced here.

Stateless tests (amd_debug, parallel) — flaky

Single failure: 00071_merge_tree_optimize_aio timed out ([ FAIL ] 600.03 sec). CI's own minimizer reports "Passes without randomization. Confirmed: the failure is caused by randomized settings" and the runner logs "NOTE: Failed 1 tests - do not block pipeline, exit with 0." MergeTree AIO test, unrelated to this PR. Safe to re-run.

Regression: iceberg_1, oauth, s3_export_part, s3_export_partition, swarms — pre-existing (version drift)

Every one of these fails at the "feature support validation" gate, not in any actual scenario logic:

• oauth → OAuth/JWT authentication is not supported by this build
• swarms → Swarm object_storage_cluster is not supported by this build
• s3_export_part / partition → Export merge tree part is not supported by this build
• iceberg_1 → Swarm object_storage_cluster_join_mode ... not supported and Iceberg partition timezone ... not supported

The shared regression suite is newer than the 26.6 build and probes features not present in this flavour. These would fail identically on the base branch and are independent of vended-credentials caching (the iceberg/oauth runs never reach the credential path — they bail at the feature check).

Grype Scan clickhouse-server — infra

Not a vulnerability finding. The scan step crashed before producing output (jq: error: Could not open file result.json, can't open 'raw.log', preceded by a pip dependency conflict), so the status resolves to "An error occurred." The keeper and -alpine server Grype scans both passed with 0 high/critical. Re-run.

PR health check

The PR itself looks healthy. All build configs with a valid cache — amd/arm debug, release, asan_ubsan, tsan, binary — are green, as are Fast test, the targeted integration and AST fuzzer jobs. No failing check touches the changed files (DatabaseDataLake*, RestCatalog*, ICatalog.h, StorageCredentials.h, Azure*, ProfileEvents.cpp) or their code paths. Bottom line: nothing to fix in this PR to make CI reflect its correctness — the board is red for reasons that predate and stand apart from it. The only genuine bug in sight is the base-branch IcebergWrites.cpp missing include above.

One non-CI note for reviewers: the PR description already flags that vended-credentials cache invalidation (auth-state snapshot check + commitSettingsChanges cache clear) was dropped from this backport. That's a functional review item, not a CI item.